lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Busch <busch...@gmail.com>
Subject Re: small improvement when no payloads?
Date Tue, 13 Nov 2007 03:25:15 GMT
Yonik Seeley wrote:
> The else clause in SegmentTermPositions.readDeltaPosition() is
> redundant and could be removed, yes?
> It's a pretty minor improvement, but this is very inner-loop stuff.
> 
> -Yonik
> 

Thanks, Yonik, you're right. We can safely remove those two lines.
TermPositions#seek() resets the two values. And
"currentFieldStoresPayloads" doesn't change unless seek() is called.

All test cases still pass after removing the else clause. I'll commit
this small change (I don't think we need to open a Jira issue).

-Michael

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message