lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Busch (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-743) IndexReader.reopen()
Date Wed, 14 Nov 2007 06:02:43 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12542332
] 

Michael Busch commented on LUCENE-743:
--------------------------------------

{quote}  
  * You should also close fieldsReader when referencedSegmentReader !=
    null, right?  (in SegmentReader.doClose)
{quote}

Yes, will do!
	
{quote}
  * In the new try/finally in reopenSegment: if you first setup
    referencedSegmentReader, then can't that finally clause just be
    clone.decRef() instead of duplicating code for decRef'ing norms,
    closeNorms(), etc.?
{quote}

Hmm, what if then in clone.close() an exception is thrown from
FieldsReader.close() or singleNormStream.close(). In that case it 
would not decRef the referenced reader. 

Hmm but actually we could change the order in close() so that 
referencedSegmentReader.decRefReaderNotNorms() is done first even
if the following close() operations don't succeed?

> IndexReader.reopen()
> --------------------
>
>                 Key: LUCENE-743
>                 URL: https://issues.apache.org/jira/browse/LUCENE-743
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>            Reporter: Otis Gospodnetic
>            Assignee: Michael Busch
>            Priority: Minor
>             Fix For: 2.3
>
>         Attachments: IndexReaderUtils.java, lucene-743-take2.patch, lucene-743-take3.patch,
lucene-743-take4.patch, lucene-743-take5.patch, lucene-743-take6.patch, lucene-743-take7.patch,
lucene-743-take8.patch, lucene-743.patch, lucene-743.patch, lucene-743.patch, MyMultiReader.java,
MySegmentReader.java, varient-no-isCloneSupported.BROKEN.patch
>
>
> This is Robert Engels' implementation of IndexReader.reopen() functionality, as a set
of 3 new classes (this was easier for him to implement, but should probably be folded into
the core, if this looks good).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message