lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tzvika Barenholz (JIRA)" <j...@apache.org>
Subject [jira] Updated: (LUCENE-1059) bad java practices which affect performance (result of code inspection)
Date Mon, 19 Nov 2007 14:57:43 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-1059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Tzvika Barenholz updated LUCENE-1059:
-------------------------------------

    Attachment: inspections.diff

patch (svn diff) that fixes the issue

> bad java practices which affect performance (result of code inspection)
> -----------------------------------------------------------------------
>
>                 Key: LUCENE-1059
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1059
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Tzvika Barenholz
>            Priority: Minor
>         Attachments: inspections.diff
>
>
> IntelliJ IDEA found the following issues in the Lucense source code and tests:
> 1) explicit for loops where calls to System.arraycopy() should have been
> 2) calls to Boolean constructor (in stead of the appropriate static method/field)
> 3) instantiation of unnecessary Integer instances for toString, instead of calling the
static one
> 4) String concatenation using + inside a call to StringBuffer.append(), in stead of chaining
the append calls
> all minor issues. patch is forthcoming.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message