lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] Updated: (LUCENE-1040) Can't quickly create StopFilter
Date Thu, 01 Nov 2007 09:41:50 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-1040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Michael McCandless updated LUCENE-1040:
---------------------------------------

    Attachment: CharArraySet.take2.patch


Woops, you're right, sorry about that, and thanks for fixing it Yonik!

I made a few small changes to your patch (attached
CharArraySet.take2.patch): there were some problems with rehashing, so
I also added a new unit test (don't forget to "svn add" before
committing!).  All tests pass.

I noticed that in your patch you now assume that String.hashCode() is
always as described in Sun's javadocs, but that makes me a little
nervous, eg:

    http://forum.java.sun.com/thread.jspa?threadID=762602&messageID=4351604

Maybe for the String case we should continue computing hashCode
ourselves?


> Can't quickly create StopFilter
> -------------------------------
>
>                 Key: LUCENE-1040
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1040
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Yonik Seeley
>            Assignee: Yonik Seeley
>         Attachments: CharArraySet.patch, CharArraySet.take2.patch
>
>
> Due to the use of CharArraySet by StopFilter, one can no longer efficiently pre-create
a Set for use by future StopFilter instances.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message