lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <>
Subject [jira] Commented: (LUCENE-743) IndexReader.reopen()
Date Tue, 13 Nov 2007 19:18:43 GMT


Michael McCandless commented on LUCENE-743:

Awesome! Thanks so much for pointing me there, Mike! I was getting a
little suicidal here already ... 

No problem, I lost some hairs tracking that one down too!!

OK, latest patch looks good!  I love the new threaded unit test.

Only two smallish comments:

  * You should also close fieldsReader when referencedSegmentReader !=
    null, right?  (in SegmentReader.doClose)

  * In the new try/finally in reopenSegment: if you first setup
    referencedSegmentReader, then can't that finally clause just be
    clone.decRef() instead of duplicating code for decRef'ing norms,
    closeNorms(), etc.?

> IndexReader.reopen()
> --------------------
>                 Key: LUCENE-743
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>            Reporter: Otis Gospodnetic
>            Assignee: Michael Busch
>            Priority: Minor
>             Fix For: 2.3
>         Attachments:, lucene-743-take2.patch, lucene-743-take3.patch,
lucene-743-take4.patch, lucene-743-take5.patch, lucene-743-take6.patch, lucene-743-take7.patch,
lucene-743-take8.patch, lucene-743.patch, lucene-743.patch, lucene-743.patch,,, varient-no-isCloneSupported.BROKEN.patch
> This is Robert Engels' implementation of IndexReader.reopen() functionality, as a set
of 3 new classes (this was easier for him to implement, but should probably be folded into
the core, if this looks good).

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message