lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1040) Can't quickly create StopFilter
Date Fri, 02 Nov 2007 19:24:50 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539677
] 

Hoss Man commented on LUCENE-1040:
----------------------------------

Hmmm... i was going to say "would one String.toLowerCase() in StopFilter.next really be any
worse then the Character.toLowerCase() that are currently done in CharArraySet?" but i suppose
it might be in the typical stopword cases where most words on stop words (so the character
based approach can short circuit early (not that i've actually benchmarked it).

i suppose it's best to leave the API as it is ... but document the hell out of when/how ignoreCase
is significant .. make it clear that the value passed to the StopFilter constructor must be
consistent with the value passed to makeStopSet if both are used (actually: we could assert
that in the StopFilter constructor if we add a CharArraySet.getIgnoreCase() method)

> Can't quickly create StopFilter
> -------------------------------
>
>                 Key: LUCENE-1040
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1040
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Yonik Seeley
>            Assignee: Yonik Seeley
>         Attachments: CharArraySet.patch, CharArraySet.take2.patch
>
>
> Due to the use of CharArraySet by StopFilter, one can no longer efficiently pre-create
a Set for use by future StopFilter instances.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message