lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <>
Subject [jira] Commented: (LUCENE-1059) bad java practices which affect performance (result of code inspection)
Date Mon, 19 Nov 2007 15:06:43 GMT


Uwe Schindler commented on LUCENE-1059:

A small speed improvement in the StringBuffer/-Builder parts could be achieved by replacing
buffer.append(String) with single-character Strings by buffer.append(char).

If we move to Java 1.5 for a later Lucene version you should replace StringBuffer by StringBuilder.

> bad java practices which affect performance (result of code inspection)
> -----------------------------------------------------------------------
>                 Key: LUCENE-1059
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Tzvika Barenholz
>            Priority: Minor
>         Attachments: inspections.diff
> IntelliJ IDEA found the following issues in the Lucense source code and tests:
> 1) explicit for loops where calls to System.arraycopy() should have been
> 2) calls to Boolean constructor (in stead of the appropriate static method/field)
> 3) instantiation of unnecessary Integer instances for toString, instead of calling the
static one
> 4) String concatenation using + inside a call to StringBuffer.append(), in stead of chaining
the append calls
> all minor issues. patch is forthcoming.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message