lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yonik Seeley (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1040) Can't quickly create StopFilter
Date Thu, 01 Nov 2007 17:44:50 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539422
] 

Yonik Seeley commented on LUCENE-1040:
--------------------------------------

> I noticed that in your patch you now assume that String.hashCode() is always as described
in Sun's javadocs

The fact that it's in their javadocs seems to make it part of the interface though.
Using String.hash (for cached strings - hashCode already calculated) resulted in a 15% lookup
improvement.

Side note: looking up char[] was faster in any event... probably because the extra bounds
checking code for every String.charAt()

On the other hand... not being tied to String.hashCode() means we could select a faster method
if we chose to do so.

> Can't quickly create StopFilter
> -------------------------------
>
>                 Key: LUCENE-1040
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1040
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Yonik Seeley
>            Assignee: Yonik Seeley
>         Attachments: CharArraySet.patch, CharArraySet.take2.patch
>
>
> Due to the use of CharArraySet by StopFilter, one can no longer efficiently pre-create
a Set for use by future StopFilter instances.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message