lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1019) CustomScoreQuery should support multiple ValueSourceQueries
Date Fri, 05 Oct 2007 01:50:50 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12532560
] 

Hoss Man commented on LUCENE-1019:
----------------------------------

this class seems to assume that the ValueSourceQueries should be multipled ... but it would
be just as easy to assume the should be added, or averaged.

It seems like it might make more sense if instead of a CustomMultiScoreQuery there was just
a "ProductValueSource" class that took in a ValueSource[] and multiplied them

> CustomScoreQuery should support multiple ValueSourceQueries
> -----------------------------------------------------------
>
>                 Key: LUCENE-1019
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1019
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Search
>    Affects Versions: 2.2
>            Reporter: Kyle Maxwell
>         Attachments: CustomMultiQuery.v0.diff
>
>
> CustomScoreQuery's constructor currently accepts a subQuery, and a ValueSourceQuery.
 I would like it to accept multiple ValueSourceQueries.  The workaround of nested CustomScoreQueries
works for simple cases, but it quickly becomes either cumbersome to manage, or impossible
to implement the desired function.
> This patch implements CustomMultiScoreQuery with my desired functionality, and refactors
CustomScoreQuery to implement the special case of a CustomMultiScoreQuery with 0 or 1 ValueSourceQueries.
 This keeps the CustomScoreQuery API intact.
> This patch includes basic tests, more or less taken from the original implementation,
and customized a bit to cover the new cases.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message