lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Busch (JIRA)" <>
Subject [jira] Commented: (LUCENE-743) IndexReader.reopen()
Date Mon, 08 Oct 2007 17:57:51 GMT


Michael Busch commented on LUCENE-743:

Thanks all for the reviews and comments!

There seem to be some issues/open questions concerning the cloning. 
Before I comment on them I think it would make sense to decide whether
we want to stick with the cloning approach or not. Mike suggests this 

> Actually if we went back to the sharing (not cloning) approach, could
> we insert a check for any writing operation against the re-opened
> reader that throws an exception if the original reader is not yet
> closed?

Interesting, yes that should work in case we have two readers (the 
original one and the re-opened one). But what happens if the user calls 
reopen twice to get two re-opened instances back? Then there would be 
three instances, and without cloning the two re-opened ones would also 
share the same resources. Is this a desirable use case or would it be 
okay to restrict reopen() so that it can only create one new instance?

> IndexReader.reopen()
> --------------------
>                 Key: LUCENE-743
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>            Reporter: Otis Gospodnetic
>            Assignee: Michael Busch
>            Priority: Minor
>             Fix For: 2.3
>         Attachments:, lucene-743-take2.patch, lucene-743.patch,
lucene-743.patch, lucene-743.patch,,, varient-no-isCloneSupported.BROKEN.patch
> This is Robert Engels' implementation of IndexReader.reopen() functionality, as a set
of 3 new classes (this was easier for him to implement, but should probably be folded into
the core, if this looks good).

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message