lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-743) IndexReader.reopen()
Date Sat, 06 Oct 2007 14:29:50 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12532877
] 

Michael McCandless commented on LUCENE-743:
-------------------------------------------


A couple other questions/points:

  * Just to verify: if you have a DirectoryIndexReader that is holding
    the write lock (because it has made changes to deletes/norms) then
    calling reopen on this reader should always return 'this', right?
    Because it has the write lock, it must be (better be!) current.

    This might be a good place to add an assert: if you are not
    current, assert that you don't have the write lock, and if you
    have the write lock, assert that you are current.

  * I think you should add "ensureOpen()" at the top of
    MultiReader.reopen(...)?

  * If an Exception is hit during reopen, what is the resulting state
    of your original reader?  I think, ideally, it is unaffected by
    the attempt to re-open?  EG if you're on the hairy edge of file
    descriptor limits, and the attempt to re-open failed because you
    hit the limit, ideally your original reader is unaffected (even if
    you specified closeOldReader=true).


> IndexReader.reopen()
> --------------------
>
>                 Key: LUCENE-743
>                 URL: https://issues.apache.org/jira/browse/LUCENE-743
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>            Reporter: Otis Gospodnetic
>            Assignee: Michael Busch
>            Priority: Minor
>             Fix For: 2.3
>
>         Attachments: IndexReaderUtils.java, lucene-743-take2.patch, lucene-743.patch,
lucene-743.patch, lucene-743.patch, MyMultiReader.java, MySegmentReader.java
>
>
> This is Robert Engels' implementation of IndexReader.reopen() functionality, as a set
of 3 new classes (this was easier for him to implement, but should probably be folded into
the core, if this looks good).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message