lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless" <luc...@mikemccandless.com>
Subject Re: adding "throws IOException" to RAMDirectory.createOutput?
Date Wed, 03 Oct 2007 15:15:33 GMT

"Yonik Seeley" <yonik@apache.org> wrote:
> On 10/3/07, Michael McCandless <lucene@mikemccandless.com> wrote:
> > As part of LUCENE-1011, I'd like to add "throws IOException" to
> > RAMDirectory.createOutput.
> >
> > It is technically an API change since it's a checked exception and
> > people may need to change source code in their apps.  However, I
> > expect very few apps would actually be affected, because the super
> > (Directory.createOutput) already throws IOException so it's only
> > apps that directly call RAMDirectory.createOutput that may need to
> > change.  EG the common use of using RAMDirectory for holding your
> > index would be unaffected by this.
> 
> Seems fine.  It seems like in general, subclasses should retain the
> exception signature of superclass methods even if they don't currently
> throw that exception (some of those were removed in the past).

Agreed.

OK I will commit.

Mike

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message