lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-986) Refactor segmentInfos from IndexReader into its subclasses
Date Tue, 18 Sep 2007 06:21:43 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12528271
] 

Hoss Man commented on LUCENE-986:
---------------------------------

Michael: I've been meaning to look at this, but haven't had the time ... your recent update
has goaded me :)

just to clarify: the patch you added on September 12th is your latest patch right?  ... it's
not clear from you comment on the 17th if you intended to attach an update and something went
wrong.

I ask because i'm haivng trouble applying the patch from the 12th ... i must be tired because
i can't understand why, it doesn't look like the files have changed since you posted the patch,
so i'm not sure what it's complaining about ...  visually everything seems to match up...

hossman@coaster:~/lucene/lucene$ svn update
At revision 576718.
hossman@coaster:~/lucene/lucene$ svn status
?      lucene-986.patch
hossman@coaster:~/lucene/lucene$ patch --dry-run -p0 -i lucene-986.patch patching file src/java/org/apache/lucene/index/DirectoryIndexReader.java
patching file src/java/org/apache/lucene/index/FilterIndexReader.java
patching file src/java/org/apache/lucene/index/IndexReader.java
patching file src/java/org/apache/lucene/index/MultiReader.java
Hunk #1 FAILED at 19.
1 out of 2 hunks FAILED -- saving rejects to file src/java/org/apache/lucene/index/MultiReader.java.rej
patching file src/java/org/apache/lucene/index/MultiSegmentReader.java
Hunk #1 FAILED at 30.
Hunk #2 FAILED at 39.
Hunk #3 FAILED at 156.
Hunk #4 FAILED at 171.
Hunk #5 FAILED at 256.
Hunk #6 FAILED at 278.
6 out of 6 hunks FAILED -- saving rejects to file src/java/org/apache/lucene/index/MultiSegmentReader.java.rej
patching file src/java/org/apache/lucene/index/ParallelReader.java
patching file src/java/org/apache/lucene/index/SegmentReader.java
Hunk #1 succeeded at 32 with fuzz 2.
patching file src/test/org/apache/lucene/index/TestMultiReader.java
hossman@coaster:~/lucene/lucene$ 


> Refactor segmentInfos from IndexReader into its subclasses
> ----------------------------------------------------------
>
>                 Key: LUCENE-986
>                 URL: https://issues.apache.org/jira/browse/LUCENE-986
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>            Reporter: Michael Busch
>            Assignee: Michael Busch
>            Priority: Minor
>             Fix For: 2.3
>
>         Attachments: lucene-986.patch
>
>
> References to segmentInfos in IndexReader cause different kinds of problems
> for subclasses of IndexReader, like e. g. MultiReader.
> Only subclasses of IndexReader that own the index directory, namely 
> SegmentReader and MultiSegmentReader, should have a SegmentInfos object
> and be able to access it.
> Further information:
> http://www.gossamer-threads.com/lists/lucene/java-dev/51808
> http://www.gossamer-threads.com/lists/lucene/java-user/52460
> A part of the refactoring work was already done in LUCENE-781

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message