lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Peter Keegan" <peterlkee...@gmail.com>
Subject Re: MMapDirectory is broken in 2.2
Date Fri, 10 Aug 2007 22:00:07 GMT
Hi Mike,

I tested the patch and it looks good.

Thanks,
Peter

On 8/10/07, Peter Keegan <peterlkeegan@gmail.com> wrote:
>
> Heck, no need to apologize - no harm done. For all the great work by you
> and others, the least I can do is help find problems ;-)
>
> Peter
>
> On 8/10/07, Michael McCandless <lucene@mikemccandless.com> wrote:
> >
> >
> > OK, sorry about this :(  I will fix.
> >
> > Mike
> >
> > "Peter Keegan" <peterlkeegan@gmail.com> wrote:
> > > >it affects both 2.2 (released ) and trunk, right?
> > >
> > > I don't have a 2.2 index to test, but the code looks the same as the
> > > trunk.
> > > It would be tricky to write a unit test for this. I only noticed
> > because
> > > query performance went down the drain.
> > >
> > > Peter
> > >
> > >
> > > On 8/10/07, Michael McCandless <lucene@mikemccandless.com> wrote:
> > > >
> > > >
> > > > Whoa, I see -- this was caused by my commit for LUCENE-888, and, it
> > > > affects both 2.2 (released ) and trunk, right?  I think the fix is
> > to
> > > > add the corresponding constructor (openInput(String name, int
> > > > bufferSize)) into MMapDirectory but have it ignore the bufferSize?
> > > >
> > > > I will open a Jira issue.  Thanks for catching this!
> > > >
> > > > Mike
> > > >
> > > > "Peter Keegan" <peterlkeegan@gmail.com > wrote:
> > > > > I have discovered a bug in 2.2 (trunk version) that prevents
> > > > > MMapDirectory
> > > > > from working. TermInfosReader has a new constructor that calls a
> > new
> > > > > version
> > > > > of FSDirectory.openInput(String, int). This new openInput
> > signature
> > > > isn't
> > > > > implemented in MMapDirectory, so FSDirectory is used instead.
> > > > >
> > > > > Should I submit this to JIRA?
> > > >
> > > >
> > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> > > > For additional commands, e-mail: java-dev-help@lucene.apache.org
> > > >
> > > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> > For additional commands, e-mail: java-dev-help@lucene.apache.org
> >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message