lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yonik Seeley" <yo...@apache.org>
Subject Re: Deprecating IndexModifier
Date Tue, 14 Aug 2007 01:55:56 GMT
On 8/12/07, Ning Li <ning.li.li@gmail.com> wrote:
> IndexWriter does everything IndexModifier does and more, except
> "deleteDocument(int doc)". Can we reach consensus on: 1 Should we
> deprecate IndexModifier before 3.0 and remove it in 3.0? 2 If so, do
> we have to add "deleteDocument(int doc)" to IndexWriter?

IMO, (1)=yes, (2)=no

> We know how to support "deleteDocument(int doc)" in IndexWriter even
> with concurrent merge (see discussion in LUCENE-847). The main
> concern, as Yonik pointed out, is how users can use it, since docids
> may change after segment merge. Is it possible to deprecate and remove
> IndexModifier without adding "deleteDocument(int doc)" to IndexWriter?
> Probably few users use IndexModifier.deleteDocument(int doc) since
> it's also the case that docids may change after segment merge.

Right.
It's not like adding deleteDocument() to IndexWriter will allow
anything written to IndexModifier to work unchanged.  So I think if we
add something like deleteDocument() to IndexWriter it should be on
it's own merits.

-Yonik

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message