Return-Path: Delivered-To: apmail-lucene-java-dev-archive@www.apache.org Received: (qmail 3348 invoked from network); 24 Jul 2007 06:17:03 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 24 Jul 2007 06:17:03 -0000 Received: (qmail 8452 invoked by uid 500); 24 Jul 2007 06:16:58 -0000 Delivered-To: apmail-lucene-java-dev-archive@lucene.apache.org Received: (qmail 8389 invoked by uid 500); 24 Jul 2007 06:16:57 -0000 Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: java-dev@lucene.apache.org Delivered-To: mailing list java-dev@lucene.apache.org Received: (qmail 8374 invoked by uid 99); 24 Jul 2007 06:16:57 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Jul 2007 23:16:57 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: neutral (herse.apache.org: local policy) Received: from [169.229.70.150] (HELO rescomp.berkeley.edu) (169.229.70.150) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Jul 2007 23:16:55 -0700 Received: by rescomp.berkeley.edu (Postfix, from userid 1007) id C10175B77E; Mon, 23 Jul 2007 23:16:33 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by rescomp.berkeley.edu (Postfix) with ESMTP id ABAE57F403 for ; Mon, 23 Jul 2007 23:16:33 -0700 (PDT) Date: Mon, 23 Jul 2007 23:16:33 -0700 (PDT) From: Chris Hostetter To: java-dev@lucene.apache.org Subject: Re: [jira] Commented: (LUCENE-781) NPE in MultiReader.isCurrent() and getVersion() In-Reply-To: <25806918.1185240871220.JavaMail.jira@brutus> Message-ID: References: <25806918.1185240871220.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Checked: Checked by ClamAV on apache.org : I think the cleanest solution here is it to separate MultiReader into two : classes: MultiSegmentReader (package-protected) and MultiReader : (public) that extends MultiSegmentReader. i'm currently on vacation and don't have as much time to review patches as i'd like (not because i'm on vacation, but because my fiance is on vacation with me) but let me just say that i aplaud you for taking this appraoch ... I have always dislliked that MultiReader was used for both of these drasticly differnet use cases, but i never had the balls to even consider such a radically simple approach. -Hoss --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org For additional commands, e-mail: java-dev-help@lucene.apache.org