Return-Path: Delivered-To: apmail-lucene-java-dev-archive@www.apache.org Received: (qmail 80628 invoked from network); 13 Jul 2007 12:59:31 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 13 Jul 2007 12:59:31 -0000 Received: (qmail 36346 invoked by uid 500); 13 Jul 2007 12:59:30 -0000 Delivered-To: apmail-lucene-java-dev-archive@lucene.apache.org Received: (qmail 36248 invoked by uid 500); 13 Jul 2007 12:59:29 -0000 Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: java-dev@lucene.apache.org Delivered-To: mailing list java-dev@lucene.apache.org Received: (qmail 35824 invoked by uid 99); 13 Jul 2007 12:59:28 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Jul 2007 05:59:28 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: neutral (herse.apache.org: local policy) Received: from [208.97.132.5] (HELO spunkymail-a14.g.dreamhost.com) (208.97.132.5) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Jul 2007 05:59:24 -0700 Received: from [192.168.0.3] (adsl-074-229-189-244.sip.rmo.bellsouth.net [74.229.189.244]) by spunkymail-a14.g.dreamhost.com (Postfix) with ESMTP id B23CD190E35 for ; Fri, 13 Jul 2007 05:59:01 -0700 (PDT) Mime-Version: 1.0 (Apple Message framework v752.3) In-Reply-To: <1184328822.14866.1199984061@webmail.messagingengine.com> References: <758071.70810.qm@web23010.mail.ird.yahoo.com> <1184328822.14866.1199984061@webmail.messagingengine.com> Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: Content-Transfer-Encoding: 7bit From: Grant Ingersoll Subject: Re: Post mortem kudos for (LUCENE-843) :) Date: Fri, 13 Jul 2007 08:59:01 -0400 To: java-dev@lucene.apache.org X-Mailer: Apple Mail (2.752.3) X-Virus-Checked: Checked by ClamAV on apache.org This is good stuff... Might be good to put a organized version of this up on the Wiki under Best Practices On Jul 13, 2007, at 8:13 AM, Michael McCandless wrote: > > Yeah it's not so easy now: Field.java does not have setters. > > You have to make your own class that implements Fieldable (or > subclasses AbstractField) and adds your own setters. Field.java is > also [currently] final so you can't subclass it. > Should we consider putting in these changes? I think it might be a little weird on the Search side to have setters for Field and it sounds like it could cause trouble for people esp. in a threaded indexing situation, but maybe I am mistaken? At any rate, it sounds like these would be good contributions as long as they are well documented. -Grant --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org For additional commands, e-mail: java-dev-help@lucene.apache.org