lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Otis Gospodnetic (JIRA)" <>
Subject [jira] Commented: (LUCENE-794) Extend contrib Highlighter to properly support phrase queries and span queries
Date Thu, 26 Jul 2007 23:39:03 GMT


Otis Gospodnetic commented on LUCENE-794:

Mark, wow, long list of files up there.  I can't tell which ones are still relevant.  Ah,
only  spanhighlighter9.patch, right?

It looks like all files in that patch are new files, that is, this is a parallel highlighter
implementation - we can leave the old one in there and commit yours without worrying about
breaking the old one.  Could you add Apache license headers to all files, switch to 2 spaces
for indentation, and then I think this can get committed?

Oh, and since contrib can be java 1.5+, I think you can use StringBuilder instead of StringBuffer,

> Extend contrib Highlighter to properly support phrase queries and span queries
> ------------------------------------------------------------------------------
>                 Key: LUCENE-794
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Other
>            Reporter: Mark Miller
>            Priority: Minor
>         Attachments:,,,,,,,,,,,,,,,,,,,,, spanhighlighter.patch,
spanhighlighter2.patch, spanhighlighter3.patch, spanhighlighter5.patch, spanhighlighter6.patch,
spanhighlighter7.patch, spanhighlighter8.patch, spanhighlighter9.patch,,,,,,
> This patch adds a new Scorer class (SpanQueryScorer) to the Highlighter package that
scores just like QueryScorer, but scores a 0 for Terms that did not cause the Query hit. This
gives 'actual' hit highlighting for the range of SpanQuerys and PhraseQuery. There is also
a new Fragmenter that attempts to fragment without breaking up Spans.
> See for some background.
> There is a dependency on MemoryIndex.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message