lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doug Cutting (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-781) NPE in MultiReader.isCurrent() and getVersion()
Date Tue, 24 Jul 2007 13:14:31 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514961
] 

Doug Cutting commented on LUCENE-781:
-------------------------------------

> MultiSegmentReader (package-protected) and MultiReader (public) that extends MultiSegmentReader

Hmm.  I've never much liked having a non-public class as a base class for a public class.
 But I can't think of a good reason, except that it makes the javadoc a bit odd, since the
non-public class is named there, when normally everything shown in javadoc is public.

> NPE in MultiReader.isCurrent() and getVersion()
> -----------------------------------------------
>
>                 Key: LUCENE-781
>                 URL: https://issues.apache.org/jira/browse/LUCENE-781
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Index
>            Reporter: Daniel Naber
>            Assignee: Michael Busch
>         Attachments: lucene-781.patch, multireader.diff, multireader.diff, multireader_test.diff,
multireader_test.diff
>
>
> I'm attaching a fix for the NPE in MultiReader.isCurrent() plus a testcase. For getVersion(),
we should throw a better exception that NPE. I will commit unless someone objects or has a
better idea.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message