Return-Path: Delivered-To: apmail-lucene-java-dev-archive@www.apache.org Received: (qmail 84691 invoked from network); 6 Jun 2007 23:37:55 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 6 Jun 2007 23:37:55 -0000 Received: (qmail 90020 invoked by uid 500); 6 Jun 2007 23:37:55 -0000 Delivered-To: apmail-lucene-java-dev-archive@lucene.apache.org Received: (qmail 89964 invoked by uid 500); 6 Jun 2007 23:37:55 -0000 Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: java-dev@lucene.apache.org Delivered-To: mailing list java-dev@lucene.apache.org Received: (qmail 89953 invoked by uid 99); 6 Jun 2007 23:37:55 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Jun 2007 16:37:55 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: neutral (herse.apache.org: local policy) Received: from [209.86.89.61] (HELO elasmtp-galgo.atl.sa.earthlink.net) (209.86.89.61) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Jun 2007 16:37:50 -0700 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=dk20050327; d=ix.netcom.com; b=lv5Lfhz7KnTGhTEUfoT6I7vuilKcP6Aj4zFX0V9i9gYRPeBP/rUbtmPvIZozm48J; h=Received:Mime-Version:In-Reply-To:References:Content-Type:Message-Id:Content-Transfer-Encoding:From:Subject:Date:To:X-Mailer:X-ELNK-Trace:X-Originating-IP; Received: from [68.255.101.246] (helo=[192.168.1.64]) by elasmtp-galgo.atl.sa.earthlink.net with asmtp (Exim 4.34) id 1Hw54C-0006Zl-SS for java-dev@lucene.apache.org; Wed, 06 Jun 2007 19:37:29 -0400 Mime-Version: 1.0 (Apple Message framework v752.3) In-Reply-To: References: Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <5CBEC64C-5425-4689-A75F-82F51D57E99D@ix.netcom.com> Content-Transfer-Encoding: 7bit From: robert engels Subject: Re: scorer.skipTo() contr Date: Wed, 6 Jun 2007 18:37:30 -0500 To: java-dev@lucene.apache.org X-Mailer: Apple Mail (2.752.3) X-ELNK-Trace: 33cbdd8ed9881ca8776432462e451d7bd15d05d9470ff710038d97ee6635145d77c3108adca9011a350badd9bab72f9c350badd9bab72f9c350badd9bab72f9c X-Originating-IP: 68.255.101.246 X-Virus-Checked: Checked by ClamAV on apache.org The method states 'greater than OR EQUAL TO' so your d1 != d2 test is invalid. It should be assert (d2>=d1) On Jun 6, 2007, at 6:30 PM, Doron Cohen wrote: > > Hi, following LUCENE-912, looking closer at skipTo() in > DisjunctionMaxScorer, it seems not to follow Scorer.skipTo() > "contract": > > "Skips to the first match beyond the current whose document > number is > greater than or equal to a given target." > > It is the "__beyond__ the current" requirement that is not satisfied. > > Enhancing QueryUtils.checkSkipTo again found many failures. Roughly > the new > test is: > > s.skipTo(n); > d1 = s.doc(); > s.skipTo(n); // n==current > d2 = s.doc(); > assert (d1 != d2) > > If failed for so many test cases that I have to suspect maybe I am > missing > something trivial? > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org > For additional commands, e-mail: java-dev-help@lucene.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org For additional commands, e-mail: java-dev-help@lucene.apache.org