Return-Path: Delivered-To: apmail-lucene-java-dev-archive@www.apache.org Received: (qmail 47858 invoked from network); 6 Jun 2007 07:29:52 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 6 Jun 2007 07:29:52 -0000 Received: (qmail 90300 invoked by uid 500); 6 Jun 2007 07:29:52 -0000 Delivered-To: apmail-lucene-java-dev-archive@lucene.apache.org Received: (qmail 89876 invoked by uid 500); 6 Jun 2007 07:29:50 -0000 Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: java-dev@lucene.apache.org Delivered-To: mailing list java-dev@lucene.apache.org Received: (qmail 89865 invoked by uid 99); 6 Jun 2007 07:29:50 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Jun 2007 00:29:50 -0700 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Jun 2007 00:29:46 -0700 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id DB1B571418E for ; Wed, 6 Jun 2007 00:29:25 -0700 (PDT) Message-ID: <3908650.1181114965878.JavaMail.jira@brutus> Date: Wed, 6 Jun 2007 00:29:25 -0700 (PDT) From: "Paul Elschot (JIRA)" To: java-dev@lucene.apache.org Subject: [jira] Commented: (LUCENE-912) DisjunctionMaxScorer.skipTo has bug that keeps it from skipping In-Reply-To: <8931351.1181112206347.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/LUCENE-912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12501827 ] Paul Elschot commented on LUCENE-912: ------------------------------------- I'm not sure, but the patch allows to increment all generators right after the first time, and that might cause it to make a mistake in the score computation for its first doc. It might be worthwhile to make DisjunctionMaxScorer use the same specialized queue/heap as DisjunctionSumScorer. Factoring this out could lead to a common superclass that provides e.g. an array of Scorers that match the disjunction. At the same time the score computations of the subscorers could be delayed until an actual score value is needed. That is a rather drastic approach, but the specialized queue/heap of DisjunctionSumScorer might also help performance of DisjunctionMaxScorer > DisjunctionMaxScorer.skipTo has bug that keeps it from skipping > --------------------------------------------------------------- > > Key: LUCENE-912 > URL: https://issues.apache.org/jira/browse/LUCENE-912 > Project: Lucene - Java > Issue Type: Bug > Affects Versions: 2.0.0, 2.1 > Reporter: Hoss Man > Fix For: 2.2 > > Attachments: dismax_skipto.patch > > > as reported on the mailing list, DisjunctionMaxScorer.skipTo is broken if called before next in some situations... > http://www.nabble.com/Potential-issue-with-DisjunctionMaxScorer-tf3846366.html#a10894987 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org For additional commands, e-mail: java-dev-help@lucene.apache.org