Return-Path: Delivered-To: apmail-lucene-java-dev-archive@www.apache.org Received: (qmail 33653 invoked from network); 21 Jun 2007 22:00:54 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 21 Jun 2007 22:00:54 -0000 Received: (qmail 26949 invoked by uid 500); 21 Jun 2007 22:00:54 -0000 Delivered-To: apmail-lucene-java-dev-archive@lucene.apache.org Received: (qmail 26916 invoked by uid 500); 21 Jun 2007 22:00:54 -0000 Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: java-dev@lucene.apache.org Delivered-To: mailing list java-dev@lucene.apache.org Received: (qmail 26905 invoked by uid 99); 21 Jun 2007 22:00:53 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Jun 2007 15:00:53 -0700 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Jun 2007 15:00:49 -0700 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 309AB7141EE for ; Thu, 21 Jun 2007 15:00:28 -0700 (PDT) Message-ID: <3426800.1182463228179.JavaMail.jira@brutus> Date: Thu, 21 Jun 2007 15:00:28 -0700 (PDT) From: "Doron Cohen (JIRA)" To: java-dev@lucene.apache.org Subject: [jira] Commented: (LUCENE-937) Make CachingTokenFilter faster In-Reply-To: <20416739.1182460946299.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/LUCENE-937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12507044 ] Doron Cohen commented on LUCENE-937: ------------------------------------ Good catch, patch look good to me. It makes sense to modify anyhow, but just wondering, - what is the performance difference? While we're looking at this, I noticed three other uses of LinkedList that can be changed to ArrayList: - DocumentWriter - CompoundFileWriter - MultipleTermPositions > Make CachingTokenFilter faster > ------------------------------ > > Key: LUCENE-937 > URL: https://issues.apache.org/jira/browse/LUCENE-937 > Project: Lucene - Java > Issue Type: Improvement > Reporter: Mark Miller > Priority: Minor > Attachments: CachingTokenFilter.patch > > > The wrong data structure was used for the CachingTokenFilter. It should be an ArrayList rather than a LinkedList. There is a noticeable difference in speed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org For additional commands, e-mail: java-dev-help@lucene.apache.org