lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-908) MANIFEST.MF cleanup (main jar and luci customizations)
Date Wed, 06 Jun 2007 21:11:26 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12502104
] 

Hoss Man commented on LUCENE-908:
---------------------------------

A couple of random thoughts...

1) macro's can take multiple optional named <element> tags to embed in their bodies
... so instead of declaring a refid for what to include in the metinf, callers of the macro
could put <metainf> call directly in the call to <jarify>

2) one way to reduce some redundancy in the build files (between jar-core, jar-demo, and war-demo)
might be to use the <manifest> task instead of the <manifest> sub element of the
<jar> task ... there are a few subtle differences but the main key is that the <manifest>
taks let's you build up a file which you can then refer to by name from the <jar> task
... we could have a single <buildmanifest> macro with all of the common attributes in
it and then it could be called from the various jar/war targets just before building the actual
jar using attributes and <element> tags to customize things that need to be different.



...neither of these are crucial, they're just things you might want to consider to keep the
build files smaller (and arguably simpler)

> MANIFEST.MF cleanup (main jar and luci customizations)
> ------------------------------------------------------
>
>                 Key: LUCENE-908
>                 URL: https://issues.apache.org/jira/browse/LUCENE-908
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Build
>            Reporter: Michael Busch
>            Assignee: Michael Busch
>            Priority: Trivial
>             Fix For: 2.2
>
>         Attachments: lucene-908.patch, LUCENE-908.patch
>
>
> there are several problems with the MANIFEST.MF file used in the core jar, and some inconsistencies
in th luci jar:
> Lucli's build.xml has an own "jar" target and does not use the jar target from common-build.xml.
The result
> is that the MANIFEST.MF file is not consistent and the META-INF dir does not contain
LICENSE.TXT and NOTICE.TXT.
> Is there a reason why lucli behaves different in this regard? If not I think we should
fix this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message