lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Busch (JIRA)" <>
Subject [jira] Commented: (LUCENE-930) fail build if contrib tests fail to compile
Date Sat, 09 Jun 2007 00:18:26 GMT


Michael Busch commented on LUCENE-930:

> would those people really care if the build took a little longer 
> because it compile the tests even though they weren't run? 

IMO this is fine.

> and since i'm not certain these additional changes will make it 
> into the 2.2 branch (not my call to make)

Since this is contrib stuff I would say it is ok to get it into
2.2 as long as we also fix the failing tests with this patch.

> fail build if contrib tests fail to compile
> -------------------------------------------
>                 Key: LUCENE-930
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Build
>    Affects Versions: 2.1
>            Reporter: Hoss Man
>            Assignee: Hoss Man
>         Attachments: LUCENE-930.patch
> spinoff of LUCENE-885, from Steven's comments...
> Looking at the current build (r545324) it looks like the some contrib failures are getting
swallowed. Things like lucli are throwing errors along the lines of
>  [subant] /home/barronpark/smparkes/work/lucene/trunk/common-build.xml:366: srcdir "/home/barronpark/smparkes/work/lucene/trunk/contrib/lucli/src/test"
does not exist!
> but these don't make it back up to the top level status.
> It looks like the current state will bubble up junit failures, but maybe not build failures?
> ...
> It's "test-compile-contrib" (if you will) that fails and rather being contrib-crawled,
that's only done as the target of "test" in each contrib directory, at which point, it's running
in the protected contrib-crawl.
> Easy enough to lift this loop into another target, e.g., build-contrib-test. And that
will start surfacing errors, which I can work through.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message