Return-Path: 
 <java-dev-return-19638-apmail-lucene-java-dev-archive=lucene.apache.org@lucene.apache.org>
Delivered-To: apmail-lucene-java-dev-archive@www.apache.org
Received: (qmail 86578 invoked from network); 16 May 2007 22:02:58 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2)
  by minotaur.apache.org with SMTP; 16 May 2007 22:02:58 -0000
Received: (qmail 22907 invoked by uid 500); 16 May 2007 22:03:02 -0000
Delivered-To: apmail-lucene-java-dev-archive@lucene.apache.org
Received: (qmail 22869 invoked by uid 500); 16 May 2007 22:03:02 -0000
Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:java-dev-help@lucene.apache.org>
List-Unsubscribe: <mailto:java-dev-unsubscribe@lucene.apache.org>
List-Post: <mailto:java-dev@lucene.apache.org>
List-Id: <java-dev.lucene.apache.org>
Reply-To: java-dev@lucene.apache.org
Delivered-To: mailing list java-dev@lucene.apache.org
Received: (qmail 22858 invoked by uid 99); 16 May 2007 22:03:02 -0000
Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 May 2007 15:03:02 -0700
X-ASF-Spam-Status: No, hits=0.0 required=10.0
	tests=
X-Spam-Check-By: apache.org
Received-SPF: neutral (herse.apache.org: local policy)
Received: from [169.229.70.167] (HELO rescomp.berkeley.edu) (169.229.70.167)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 May 2007 15:02:53 -0700
Received: by rescomp.berkeley.edu (Postfix, from userid 1007)
	id F059D5B766; Wed, 16 May 2007 15:02:32 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1])
	by rescomp.berkeley.edu (Postfix) with ESMTP id DFF557F403
	for <java-dev@lucene.apache.org>; Wed, 16 May 2007 15:02:32 -0700 (PDT)
Date: Wed, 16 May 2007 15:02:32 -0700 (PDT)
From: Chris Hostetter <hossman_lucene@fucit.org>
To: Lucene Dev <java-dev@lucene.apache.org>
Subject: Tests, Contribs, and Releases
Message-ID: <Pine.LNX.4.58.0705161448590.24573@hal.rescomp.berkeley.edu>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Virus-Checked: Checked by ClamAV on apache.org


Hey everybody, this thread has been sitting in my inbox for a while
waiting for me to have a few minutes to look into it...

http://www.nabble.com/Packaging-Lucene-2.1.0-for-Debian--found-2-junit-errors-tf3571676.html

In a nutshell, when a guy from Debian went looking to package Lucene he
noticed that the official 2.1.0 release contained 2 test failures -- one
each in the highlighter and spellchecker contribs.

The specifics of the test failures don't really interest me as much as the
question: how did we manage to have a release with test failures?

A few things have jumped out at me while looking into this...

1) the task "build-contrib" can be used to walk the contrib directory
   building each contrib, the task "test-contrib" can be used to walk the
   contrib directory testing each contrib.
2) the "test" task only tests the lucene-core ... it does not depend on
   (or call) "test-contrib"
3) The "nightly" build task depends on the "test" and "package-tgz" task
   (which depends on "build-contrib") but at no point is "test-contrib"
   run.
4) The steps for creating an official release...
      http://wiki.apache.org/lucene-java/ReleaseTodo
   ...specify using the "dist" and
   "dist-src" tasks -- neither of which depend on *ANY* tests being run
   (let alone contrib tests)

This seems very strange to me ... i would think that we would want:

  a) nightly builds to run the tests for all contribs, ala...
     <target name="nightly" depends="test, build-contrib, test-contrib, package-tgz">
  b) the release insctructions to make it clear that all unit tests (core
     and contrib) should be run prior to creating teh distribution.


Does anyone see any reason not to make these changes?



-Hoss


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org