lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chris Hostetter <>
Subject Tests, Contribs, and Releases
Date Wed, 16 May 2007 22:02:32 GMT

Hey everybody, this thread has been sitting in my inbox for a while
waiting for me to have a few minutes to look into it...

In a nutshell, when a guy from Debian went looking to package Lucene he
noticed that the official 2.1.0 release contained 2 test failures -- one
each in the highlighter and spellchecker contribs.

The specifics of the test failures don't really interest me as much as the
question: how did we manage to have a release with test failures?

A few things have jumped out at me while looking into this...

1) the task "build-contrib" can be used to walk the contrib directory
   building each contrib, the task "test-contrib" can be used to walk the
   contrib directory testing each contrib.
2) the "test" task only tests the lucene-core ... it does not depend on
   (or call) "test-contrib"
3) The "nightly" build task depends on the "test" and "package-tgz" task
   (which depends on "build-contrib") but at no point is "test-contrib"
4) The steps for creating an official release...
   ...specify using the "dist" and
   "dist-src" tasks -- neither of which depend on *ANY* tests being run
   (let alone contrib tests)

This seems very strange to me ... i would think that we would want:

  a) nightly builds to run the tests for all contribs, ala...
     <target name="nightly" depends="test, build-contrib, test-contrib, package-tgz">
  b) the release insctructions to make it clear that all unit tests (core
     and contrib) should be run prior to creating teh distribution.

Does anyone see any reason not to make these changes?


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message