lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <>
Subject [jira] Updated: (LUCENE-885) clean up build files so contrib tests are run more easily
Date Sat, 19 May 2007 01:06:16 GMT


Hoss Man updated LUCENE-885:

    Attachment: LUCENE-885.patch

Whileworking on this, i fixed a few general issues with the way some contribs could be built/tested
easily from their own directory, but not as part of hte larger "build-contrib" "test-contrib"
targets, items included in this patch...

1) change the main "test" target to "test-core" and add a new "test" target which depends
on test and test-contrib
2) change "test.classpath" reference to include core test classes (which some contrib test
classes have compile dependencies on)
3) make xml-query-parser's dependency on the queries contrib more standardized so the queries
jar is forcably built no matter how xml-query-parser is built
4) fix MemoryIndexTest so it can find the input files it's looking at regardless of what directory
the test is run from.
5) make the generate-test-reports target work both for individual contribs as well as for
hte project as a whole
6) make contrib-crawl fail by default if the target fails for any of the contribs (so build-contrib
now fails immediately if a contrib fails to build)
7) make test-contrib delay any failure until all contribs have been tested -- this makes it
possible to run "ant generate-test-reports" after a failed "ant test" and see all of the failures.

Note that i only modified contribs in cases where they had problems related to their expectations
about being built or tested in a specific directory ... as it stands there are still some
test errors/failures...

  #a) TestPrecedenceQueryParser has 3 failures
  #b) spellchecker has one test failure (i believe there is already a patch in another issue)
  #c) contrib/db/bdb has dependencies on a native library

#a and #b are related to functionality ... i have no qualms about them being broken and preventing
builds until decisisons are made about how to fix them correctly.

#c on the other hand raises some interesting questions: should we skip those tests unless
the native library is present? ... i'm not even sure how to do that (<available> on
a classpath resource i understand, java.library.path i don't).  Are committers preparing official
releases expected to have those native libraries in order to sign off on the build?  

I'm happy to commit this as is and let the nightly builds be broken until we deal with this
... but it would be nice if at least one other person could try it out an verify that it works
for them as well.

> clean up build files so contrib tests are run more easily
> ---------------------------------------------------------
>                 Key: LUCENE-885
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Build
>            Reporter: Hoss Man
>         Assigned To: Hoss Man
>         Attachments: LUCENE-885.patch
> Per mailing list discussion...
> Tests for contribs should be run when "ant test" is used,  existing "test" target renamed
to "test-core"

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message