lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Busch (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-698) FilteredQuery ignores boost
Date Tue, 29 May 2007 02:06:15 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12499658
] 

Michael Busch commented on LUCENE-698:
--------------------------------------

> perhaps it should test if either the score or the explanation value are NaN 
> before comparing them, and fail if only one is NaN or if neither is NaN but 
> they are not equal)

Thanks for reviewing, Hoss! You are right, we could do that and I was actually
thinking about it already. The problem is if I make this fix than testFQ7 fails
for TestSimpleExplanationsOfNonMatches because it is assumed that all
non matching docs have a score of 0.0. I can easily change that, so that non
matching docs can either have a score of 0.0 or NaN but I was not sure if we
want that, because other scoring bugs resulting in a score of NaN (which we 
will hopefully never have) wouldn't be noticed then anymore.

The reason why I argued that testFQ7 is an invalid test case is that it would
fail for any other query with a boost set to 0. Ironically we have this test
only for FilteredQuery, the only query class that ignores the boost, which
made it pass in the past.

> FilteredQuery ignores boost
> ---------------------------
>
>                 Key: LUCENE-698
>                 URL: https://issues.apache.org/jira/browse/LUCENE-698
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Search
>    Affects Versions: 2.0.0
>            Reporter: Yonik Seeley
>            Assignee: Michael Busch
>            Priority: Minor
>         Attachments: lucene-698.patch
>
>
> Filtered query ignores it's own boost.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message