Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: java-dev@lucene.apache.org
Received-SPF: pass (herse.apache.org: local policy)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=yahoo.com;
  h=X-YMail-OSG:Received:X-Mailer:Date:From:Subject:To:MIME-Version:Content-Type:Message-ID;
  b=o5c3Mc+XLQzyLbPWURXGwjUmm+vqHlUHMNDMzz4JxtrBkjM4bP/shaReXI/agWhyCDmdz5DKU4wdAsg+aU0gT1InfWepuTEQG/9y7ZhDzYmXdWFBVmn6OohzRWuOSDXZaHmJ+Apk4thHmVFJWth8Pzuq472glZeqaufzUDZqYus=;
Date: Thu, 5 Apr 2007 10:51:04 -0700 (PDT)
From: Otis Gospodnetic <otis_gospodnetic@yahoo.com>
Subject: Re: svn commit: r525669 -
 /lucene/java/trunk/src/java/org/apache/lucene/search/BooleanScorer.java
To: java-dev@lucene.apache.org
MIME-Version: 1.0
Content-Type: text/plain; charset=ascii
Message-ID: <447175.96061.qm@web50301.mail.re2.yahoo.com>

Nothing fancy - Eclipse.  It flagged it, I removed it, nothing "turned red" indicating everything still compiled, unit tests still passed, committed.

If I recall correctly, one has to configure Eclipse to alert you to unused variables, methods, and such, and I have that turned on.

Otis 
. . . . . . . . . . . . . . . . . . . . . . . . . . . . . .
Simpy -- http://www.simpy.com/  -  Tag  -  Search  -  Share

----- Original Message ----
From: Paul Elschot <paul.elschot@xs4all.nl>
To: java-commits@lucene.apache.org
Sent: Thursday, April 5, 2007 4:14:23 AM
Subject: Re: svn commit: r525669 - /lucene/java/trunk/src/java/org/apache/lucene/search/BooleanScorer.java

Otis,

Can I ask which tool you used to catch this, and the previous one?

Regards,
Paul Elschot


On Thursday 05 April 2007 03:06, otis@apache.org wrote:
> Author: otis
> Date: Wed Apr  4 18:06:16 2007
> New Revision: 525669
> 
> URL: http://svn.apache.org/viewvc?view=rev&rev=525669
> Log:
> - Removed unused BooleanScore param passed to the inner BucketTable class
> 
> Modified:
>     lucene/java/trunk/src/java/org/apache/lucene/search/BooleanScorer.java
> 
> Modified: 
lucene/java/trunk/src/java/org/apache/lucene/search/BooleanScorer.java
> URL: 
http://svn.apache.org/viewvc/lucene/java/trunk/src/java/org/apache/lucene/search/BooleanScorer.java?view=diff&rev=525669&r1=525668&r2=525669
> 
==============================================================================
> --- lucene/java/trunk/src/java/org/apache/lucene/search/BooleanScorer.java 
(original)
> +++ lucene/java/trunk/src/java/org/apache/lucene/search/BooleanScorer.java 
Wed Apr  4 18:06:16 2007
> @@ -21,7 +21,7 @@
>  
>  final class BooleanScorer extends Scorer {
>    private SubScorer scorers = null;
> -  private BucketTable bucketTable = new BucketTable(this);
> +  private BucketTable bucketTable = new BucketTable();
>  
>    private int maxCoord = 1;
>    private float[] coordFactors = null;
> @@ -201,11 +201,7 @@
>      final Bucket[] buckets = new Bucket[SIZE];
>      Bucket first = null;                          // head of valid list
>    
> -    private BooleanScorer scorer;
> -
> -    public BucketTable(BooleanScorer scorer) {
> -      this.scorer = scorer;
> -    }
> +    public BucketTable() {}
>  
>      public final int size() { return SIZE; }
>  
> 
> 
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org