lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From eks dev <>
Subject Re: [jira] Commented: (LUCENE-584) Decouple Filter from BitSet
Date Fri, 13 Apr 2007 20:10:39 GMT
Hoss, would this work (is this what you said)? 
public BitSet bits(IndexReader reader) throws IOException{
 return null;

public Matcher getMatcher(IndexReader reader) throws IOException {
  if(bits() == null) throw new SomeException("Filter must implement at least one of...");

  return new BitsMatcher(bits());

and IndexSearcher does not have any logic, just uses getMatcher()
current implementations would work, new as well

----- Original Message ----
From: Hoss Man (JIRA) <>
Sent: Friday, 13 April, 2007 8:01:16 PM
Subject: [jira] Commented: (LUCENE-584) Decouple Filter from BitSet


Hoss Man commented on LUCENE-584:

I'm still behind on following this issue, but Otis: if you are interested in moving forward
with this, you might consider trying the cahnges i proposed in my "15/Mar/07 11:06 AM" Comment...

...I think it would keep IndexSearcher a little cleaner, and make it easier for people to
migrate existing Filter's gradually (without requiring extra work for people writing new "Matcher"
style Filters from scratch)

> Decouple Filter from BitSet
> ---------------------------
>                 Key: LUCENE-584
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Search
>    Affects Versions: 2.0.1
>            Reporter: Peter Schäfer
>            Priority: Minor
>         Attachments: bench-diff.txt, bench-diff.txt,, Filter-20060628.patch,
HitCollector-20060628.patch, IndexSearcher-20060628.patch,,,
Matcher20070226.patch, Scorer-20060628.patch, Searchable-20060628.patch, Searcher-20060628.patch,
> {code}
> package;
> public abstract class Filter implements 
> {
>   public abstract AbstractBitSet bits(IndexReader reader) throws IOException;
> }
> public interface AbstractBitSet 
> {
>   public boolean get(int index);
> }
> {code}
> It would be useful if the method =Filter.bits()= returned an abstract interface, instead
of =java.util.BitSet=.
> Use case: there is a very large index, and, depending on the user's privileges, only
a small portion of the index is actually visible.
> Sparsely populated =java.util.BitSet=s are not efficient and waste lots of memory. It
would be desirable to have an alternative BitSet implementation with smaller memory footprint.
> Though it _is_ possibly to derive classes from =java.util.BitSet=, it was obviously not
designed for that purpose.
> That's why I propose to use an interface instead. The default implementation could still
delegate to =java.util.BitSet=.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

Yahoo! Mail is the world's favourite email. Don't settle for less, sign up for
your free account today*

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message