lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doron Cohen (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (LUCENE-789) Custom similarity is ignored when using MultiSearcher
Date Wed, 25 Apr 2007 21:17:15 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Doron Cohen resolved LUCENE-789.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 2.2

Fix committed, thanks Alexey!

It should be noted that as before this fix, creating a multiSearcher from Searchers for whom
custom similarity was set has no effect - the custom similarities of those searchers are masked
by the similarity of the MultiSearcher. This is as designed, because MultiSearcher operates
on Searchables (not on Searchers).

> Custom similarity is ignored when using MultiSearcher
> -----------------------------------------------------
>
>                 Key: LUCENE-789
>                 URL: https://issues.apache.org/jira/browse/LUCENE-789
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Search
>    Affects Versions: 2.0.1
>            Reporter: Alexey Lef
>         Assigned To: Doron Cohen
>             Fix For: 2.2
>
>         Attachments: 789_patch.txt, TestMultiSearcherSimilarity.java
>
>
> Symptoms:
> I am using Searcher.setSimilarity() to provide a custom similarity that turns off tf()
factor. However, somewhere along the way the custom similarity is ignored and the DefaultSimilarity
is used. I am using MultiSearcher and BooleanQuery.
> Problem analysis:
> The problem seems to be in MultiSearcher.createWeight(Query) method. It creates an instance
of CachedDfSource but does not set the similarity. As the result CachedDfSource provides DefaultSimilarity
to queries that use it.
> Potential solution:
> Adding the following line:
>     cacheSim.setSimilarity(getSimilarity());
> after creating an instance of CacheDfSource (line 312) seems to fix the problem. However,
I don't understand enough of the inner workings of this class to be absolutely sure that this
is the right thing to do.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message