lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-821) single norm file still uses up descriptors
Date Sat, 03 Mar 2007 23:24:50 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12477706
] 

Michael McCandless commented on LUCENE-821:
-------------------------------------------

Whoa, you beat me to it: this was the next bug I was about to open!

And I had worked through a patch, even setting in = null in the newly
added Norm.close method :)

And then also re-discovering that TestMultiSearcher closes its
searcher and then keeps using it...

Your patch looks perfect to me.  +1

I like the removal of the .clone() since norms(...) is synchronized.

The one thing I was still trying to work out is if we could somehow
close the singleNormStream once all Norm instances that share it had
cached.  It seems like a nice to have, but, since norms(...) is
already synchronized we could have a simple refcount to track how many
Norm instances still required it and then close the stream when that
hits 0?  This way we can free up 1 more file descriptor in certain
cases.

> single norm file still uses up descriptors
> ------------------------------------------
>
>                 Key: LUCENE-821
>                 URL: https://issues.apache.org/jira/browse/LUCENE-821
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Yonik Seeley
>         Assigned To: Yonik Seeley
>         Attachments: norms.patch
>
>
> The new index file format with a single .nrm file for all norms does not decrease file
descriptor usage.
> The .nrm file is opened once for each field with norms in the index segment.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message