lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <>
Subject [jira] Commented: (LUCENE-818) IndexWriter should detect when it's used after being closed
Date Mon, 05 Mar 2007 21:33:51 GMT


Hoss Man commented on LUCENE-818:

1) my example attempted to be concise ... ideally we would be explicit in our catches.

2) the body of the catch clauses could be put into a helper method just like ensureOpen to
help reduce code noise

3) if there are situations where damage will be done by not testing that we are open before
taking some action, that would fall under my "adding better error checking in those specific
cases (if we know of any) and throwing explicit exceptions." ... a lot of this could be achieved
(as Yonik suggested) by nulling out more things in close so that the first attempt to do something
dangerous after the close triggered a NullPointerException.

4) "fail fast" is always good ... except when it makes the non-failure case slow ... i was
merely suggesting an alternative that would achieve the same results without penalizing performance
of people obeying the rules.

as an added bonus, both methodologies could be used... 

if numDoc(), maxDoc(), isDeleted(), and hasDeletions() are the only mehtods were people are
concerned about the performance impacts of calling ensureOpen() everytime, then those methods
could be the ones where isOpen could be checked in any exception handling block, and all of
the other mehtods could use ensureOpen as orriginal described.

> IndexWriter should detect when it's used after being closed
> -----------------------------------------------------------
>                 Key: LUCENE-818
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Index
>    Affects Versions: 2.1
>            Reporter: Michael McCandless
>         Assigned To: Michael McCandless
>            Priority: Minor
>         Attachments: LUCENE-818.patch, LUCENE-818.take2.patch, LUCENE-818.take3.patch
> Spinoff from this thread on java-user:
> If you call addDocument on IndexWriter after it's closed you'll hit a
> hard-to-explain NullPointerException (because the RAMDirectory was
> closed).  Before 2.1, apparently you won't hit any exception and the
> IndexWrite will keep running but will have released it's write lock (I
> think).
> I plan to fix IndexWriter methods to throw an IllegalStateException if
> it has been closed.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message