lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steven Parkes (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-814) javacc on Win32 (cygwin) creates wrong line endings - fix them with 'ant replace'
Date Tue, 06 Mar 2007 20:30:24 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12478562
] 

Steven Parkes commented on LUCENE-814:
--------------------------------------

What's the reasoning behind the 100ms sleep? If it's to handle FAT file systems, I thought
their resolution was 2s, so 100ms isn't guaranteed to be enough?

I guess it depends on whether you know what javacc is doing. This article
http://msdn2.microsoft.com/en-us/library/ms724290.aspx
http://tinyurl.com/3xp6ou
says create time is good to 10ms but that write time is only good to 2s. If javacc is rewriting,
this might not work but if it always deletes and creates, it sounds like it would be. (I don't
have a FAT system around to test this on).

I'm beginning to wonder if this isn't overkill. We already list a bunch of files (a list I'm
not longer sure is complete) for the clean-javacc task.

> javacc on Win32 (cygwin) creates wrong line endings - fix them with 'ant replace'
> ---------------------------------------------------------------------------------
>
>                 Key: LUCENE-814
>                 URL: https://issues.apache.org/jira/browse/LUCENE-814
>             Project: Lucene - Java
>          Issue Type: Task
>          Components: Build
>         Environment: Windows, Cygwin
>            Reporter: Doron Cohen
>         Assigned To: Doron Cohen
>            Priority: Minor
>             Fix For: 2.2
>
>         Attachments: 814.javacc.fixcrlf.common-build.patch, 814.javacc.fixcrlf.common-build.patch,
814.javacc.fixcrlf.common-build.patch, 814.javacc.line.ends.patch, LUCENE-814.txt, LUCENE-814.txt
>
>
> "ant javacc" in Windows/Cygwin generates files with wrong line endings (\r  or \r\n instead
of *Nix's \n). 
> I managed to get rid of those using    perl -p -e 's/(\r\n|\n|\r)/\n/g'
> Some useful info on line ending issues is in http://en.wikipedia.org/wiki/Newline
> After wasting some time to get rid of those, I modified javacc-QueryParser build.xml
task to take care of that.
> So now QueryParser files created with "ant javacc" are fixed (if required) to have \n
as line ends.
> Should probably do that also for the other javacc targets: javacc-HTMLParser and javacc-StandardAnalyzer(?)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message