lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joe Shaw (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-431) RAMInputStream and RAMOutputStream without further buffering
Date Tue, 27 Mar 2007 22:41:32 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12484632
] 

Joe Shaw commented on LUCENE-431:
---------------------------------

Michael: mysterious patch failures like that are usually caused by problems with line endings.
 Try running dos2unix on the patch and then apply it.

> RAMInputStream and RAMOutputStream without further buffering
> ------------------------------------------------------------
>
>                 Key: LUCENE-431
>                 URL: https://issues.apache.org/jira/browse/LUCENE-431
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Store
>    Affects Versions: CVS Nightly - Specify date in submission
>         Environment: Operating System: other
> Platform: Other
>            Reporter: Paul Elschot
>         Assigned To: Michael Busch
>            Priority: Minor
>         Attachments: lucene-431.patch, lucene-431.zip, RAMInputStream.java
>
>
> From java-dev, Doug's reply of 12 Sep 2005 
> on Delaying buffer allocation in BufferedIndexInput: 
>  
> Paul Elschot wrote: 
> ... 
> > I noticed that RAMIndexInput extends BufferedIndexInput. 
> > It has all data in buffers already, so why is there another 
> > layer of buffering? 
>  
> No good reason: it's historical. 
>  
> To avoid this either: (a) the BufferedIndexInput API would need to be  
> modified to permit subclasses to supply the buffer; or (b)  
> RAMInputStream could subclass IndexInput directly, using its own  
> buffers.  The latter would probably be simpler. 
>  
> End of quote. 
>  
> I made version (b) of RAMInputStream. 
> Using this RAMInputStream, TestTermVectorsReader failed as the only 
> failing test.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message