Return-Path: Delivered-To: apmail-lucene-java-dev-archive@www.apache.org Received: (qmail 71689 invoked from network); 28 Feb 2007 18:31:21 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 28 Feb 2007 18:31:21 -0000 Received: (qmail 14754 invoked by uid 500); 28 Feb 2007 18:31:26 -0000 Delivered-To: apmail-lucene-java-dev-archive@lucene.apache.org Received: (qmail 14704 invoked by uid 500); 28 Feb 2007 18:31:26 -0000 Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: java-dev@lucene.apache.org Delivered-To: mailing list java-dev@lucene.apache.org Received: (qmail 14673 invoked by uid 99); 28 Feb 2007 18:31:26 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Feb 2007 10:31:26 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Feb 2007 10:31:17 -0800 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 1EF44714046 for ; Wed, 28 Feb 2007 10:30:57 -0800 (PST) Message-ID: <6401080.1172687457123.JavaMail.jira@brutus> Date: Wed, 28 Feb 2007 10:30:57 -0800 (PST) From: "Dan Zivkovic (JIRA)" To: java-dev@lucene.apache.org Subject: [jira] Commented: (LUCENE-819) NullPointerException in Term.compareTo() In-Reply-To: <9238613.1172592725549.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/LUCENE-819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12476664 ] Dan Zivkovic commented on LUCENE-819: ------------------------------------- Empty string or null would be the same thing from the point of view of our application. And it would be preferable to an exception coming from a place that didn't use to throw one. I still don't see the big deal in checking for null, however. If the fix is simple and it's tested and it doesn't affect anyone who does NOT have nulls in their terms, then why not just apply the patch and move on? > NullPointerException in Term.compareTo() > ---------------------------------------- > > Key: LUCENE-819 > URL: https://issues.apache.org/jira/browse/LUCENE-819 > Project: Lucene - Java > Issue Type: Bug > Components: Index > Environment: JDK 1.4 on MacOS > Reporter: Dan Zivkovic > Attachments: lucene-819.patch, lucene-819.patch, TestTerm.java > > > java.lang.NullPointerException > at org.apache.lucene.index.Term.compareTo(Term.java:84) > at org.apache.lucene.index.TermInfosReader.getIndexOffset(TermInfosReader.java:115) > at org.apache.lucene.index.TermInfosReader.get(TermInfosReader.java:150) > at org.apache.lucene.index.SegmentReader.docFreq(SegmentReader.java:300) > at org.apache.lucene.search.IndexSearcher.docFreq(IndexSearcher.java:78) > at org.apache.lucene.search.Similarity.idf(Similarity.java:255) > at org.apache.lucene.search.TermQuery$TermWeight.(TermQuery.java:43) > at org.apache.lucene.search.TermQuery.createWeight(TermQuery.java:142) > at org.apache.lucene.search.BooleanQuery$BooleanWeight.(BooleanQuery.java:203) > at org.apache.lucene.search.BooleanQuery$BooleanWeight2.(BooleanQuery.java:330) > at org.apache.lucene.search.BooleanQuery.createWeight(BooleanQuery.java:372) > at org.apache.lucene.search.Query.weight(Query.java:93) > at org.apache.lucene.search.Hits.(Hits.java:48) > at org.apache.lucene.search.Searcher.search(Searcher.java:53) > ... -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org For additional commands, e-mail: java-dev-help@lucene.apache.org