Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: java-dev@lucene.apache.org
Received-SPF: pass (herse.apache.org: local policy)
Message-ID: <45C4CE35.8030104@mikemccandless.com>
Date: Sat, 03 Feb 2007 13:02:29 -0500
From: Michael McCandless <lucene@mikemccandless.com>
User-Agent: Thunderbird 1.5.0.9 (Windows/20061207)
MIME-Version: 1.0
To: java-dev@lucene.apache.org
Subject: Re: deprecate Directory.renameFile()?
References: <200702031739.34400@danielnaber.de>
In-Reply-To: <200702031739.34400@danielnaber.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Daniel Naber wrote:

> I see that Directory.renameFile() isn't used anymore. I assume it has only 
> been public for technical reasons, not because we expect this to be used 
> from outside of Lucene? Should we deprecate this method? Its 
> implementation e.g. in FSDirectory looks a bit scary anyway (the comment 
> correctly says "This is not atomic" while the abstract class says "This 
> replacement should be atomic").

Oh, good catch!  I agree it should be deprecated.  In addition to
the non-atomic issue, that method is also problematic on Windows
(intermittent access denied errors, LUCENE-665).  Let's deprecate it
before 2.1?

Mike

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org