lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael McCandless <luc...@mikemccandless.com>
Subject Re: deprecate Directory.renameFile()?
Date Sat, 03 Feb 2007 18:02:29 GMT
Daniel Naber wrote:

> I see that Directory.renameFile() isn't used anymore. I assume it has only 
> been public for technical reasons, not because we expect this to be used 
> from outside of Lucene? Should we deprecate this method? Its 
> implementation e.g. in FSDirectory looks a bit scary anyway (the comment 
> correctly says "This is not atomic" while the abstract class says "This 
> replacement should be atomic").

Oh, good catch!  I agree it should be deprecated.  In addition to
the non-atomic issue, that method is also problematic on Windows
(intermittent access denied errors, LUCENE-665).  Let's deprecate it
before 2.1?

Mike

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message