lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Miller (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-794) Beginnings of a span based highlighter
Date Tue, 20 Feb 2007 22:18:05 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12474582
] 

Mark Miller commented on LUCENE-794:
------------------------------------

Almost at the holy grail here. Everything works except the optional ignoring fields in the
Query object. Scores work, all other tests pass, and even better there is no more limitation
of only highlighting the first and last term in a Span -- instead all correct terms in each
Span will be highlighted. The only change to the existing code I had to make was to add a
parameter to scoreToken(Token token) -- I had to add int position.

I still think it is very feasible to pass info from this SpanScorer to a Fragmenter so that
the Freagmenter can attempt to avoid splitting up Spans.

The current code will correctly highlight pretty much any standard or span query ( I think
<g>) based on 'actual' hits using the exisiting contrib highlighter code...I have yet
to write out the new extensive Span tests and I would appreciate it if some others would go
over the code for some obvious improvements, but this is almost ready.

Get the latests:
SpanScorer
SpanQueryExtractor
CachedTokenStream
SpanHighlighterTest 
WeightedSpanTerm
Highlighter

- Mark

> Beginnings of a span based highlighter
> --------------------------------------
>
>                 Key: LUCENE-794
>                 URL: https://issues.apache.org/jira/browse/LUCENE-794
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Other
>            Reporter: Mark Miller
>            Priority: Minor
>         Attachments: CachedTokenStream.java, CachedTokenStream.java, CachedTokenStream.java,
DefaultEncoder.java, Encoder.java, Formatter.java, Highlighter.java, Highlighter.java, Highlighter.java,
Highlighter.java, Highlighter.java, HighlighterTest.java, HighlighterTest.java, HighlighterTest.java,
HighlighterTest.java, MemoryIndex.java, QuerySpansExtractor.java, QuerySpansExtractor.java,
QuerySpansExtractor.java, QuerySpansExtractor.java, SimpleFormatter.java, SpanHighlighterTest.java,
SpanHighlighterTest.java, SpanScorer.java, SpanScorer.java, WeightedSpanTerm.java
>
>
> This is some test code to start the work of adding a span based highlighting approach
to the existing highlighter in contrib. See http://issues.apache.org/jira/browse/LUCENE-403
for some background.
> There is a dependency on MemoryIndex.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message