lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Miller (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-794) Beginnings of a span based highlighter
Date Mon, 05 Feb 2007 22:24:05 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12470379
] 

Mark Miller commented on LUCENE-794:
------------------------------------

I switched to accepting an analyzer and a field name. I need the field name anyway for the
MemoryIndex.

 I agree that modifying MemoryIndex was horrible and I have removed that dependency (just
did it as a 'quickfix'). 

I used the CachedTokenStream anyway to avoid analyzing twice (once for MemoryIndex and again
for Highlighter use. Thanks for the idea...shows how bright I am having missed it <g>).

I removed all of the 1.5 code.

The code is probably fairly usable right now then. I think synonyms work fine unless a case
does exist like you suggested.

So I suppose we have 4 options:

1. I extend and polish the code (needs more test cases, most of mine where written using my
query parser) and it is used independently for full document highlighting based on spans.
(I would like to add google cache like coloring)

2. The code is either merged with the existing highlighter or gutted to create a single highlighter
that can fragment based on spans or based on the original term based approach.

3. The code is ignored and someone else starts fresh adding span support to the existing highlighter.

4. The code languishes in purgatory and we await the unknown.

- Mark M



> Beginnings of a span based highlighter
> --------------------------------------
>
>                 Key: LUCENE-794
>                 URL: https://issues.apache.org/jira/browse/LUCENE-794
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Other
>            Reporter: Mark Miller
>            Priority: Minor
>         Attachments: CachedTokenStream.java, DefaultEncoder.java, Encoder.java, Formatter.java,
Highlighter.java, Highlighter.java, Highlighter.java, HighlighterTest.java, HighlighterTest.java,
HighlighterTest.java, MemoryIndex.java, QuerySpansExtractor.java, SimpleFormatter.java
>
>
> This is some test code to start the work of adding a span based highlighting approach
to the existing highlighter in contrib. See http://issues.apache.org/jira/browse/LUCENE-403
for some background.
> There is a dependency on MemoryIndex.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message