lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-814) javacc on Win32 (cygwin) creates wrong line endings - fix them with 'ant replace'
Date Tue, 27 Feb 2007 08:10:05 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12476091
] 

Hoss Man commented on LUCENE-814:
---------------------------------

i *think* the right solution is to leave the .jj and .java files with svn:eol-style=native,
then modify any target which regenerates a .java file from a.jj file to use <fixCRLF>
without specifying either the "eol" or "cr" attributes ... the default of <fixCRLF>
is to convert the file to the native format ... so it should synx up.

...but i haven't tested this (no access to windows/cygwin) so i'm not positive it works.

if that doesn't work, the safest thing to do might be to set svn:eol-style=CRLF (or any other
non variable value) for all of hte generated but commited .java files, and then modify the
ant task that generates them to call <fixCRLF eol="CRLF"> on those files.


(incidently: are you sure that if you do *everything* in cygwin -- both the checkout and running
"ant javacc" -- you don't wind up with unix style line endings on all files?)

> javacc on Win32 (cygwin) creates wrong line endings - fix them with 'ant replace'
> ---------------------------------------------------------------------------------
>
>                 Key: LUCENE-814
>                 URL: https://issues.apache.org/jira/browse/LUCENE-814
>             Project: Lucene - Java
>          Issue Type: Task
>          Components: Build
>         Environment: Windows, Cygwin
>            Reporter: Doron Cohen
>         Assigned To: Doron Cohen
>            Priority: Minor
>             Fix For: 2.1
>
>         Attachments: 814.javacc.line.ends.patch
>
>
> "ant javacc" in Windows/Cygwin generates files with wrong line endings (\r  or \r\n instead
of *Nix's \n). 
> I managed to get rid of those using    perl -p -e 's/(\r\n|\n|\r)/\n/g'
> Some useful info on line ending issues is in http://en.wikipedia.org/wiki/Newline
> After wasting some time to get rid of those, I modified javacc-QueryParser build.xml
task to take care of that.
> So now QueryParser files created with "ant javacc" are fixed (if required) to have \n
as line ends.
> Should probably do that also for the other javacc targets: javacc-HTMLParser and javacc-StandardAnalyzer(?)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message