Return-Path: Delivered-To: apmail-lucene-java-dev-archive@www.apache.org Received: (qmail 67237 invoked from network); 19 Dec 2006 20:36:22 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 19 Dec 2006 20:36:22 -0000 Received: (qmail 11090 invoked by uid 500); 19 Dec 2006 20:36:26 -0000 Delivered-To: apmail-lucene-java-dev-archive@lucene.apache.org Received: (qmail 11058 invoked by uid 500); 19 Dec 2006 20:36:26 -0000 Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: java-dev@lucene.apache.org Delivered-To: mailing list java-dev@lucene.apache.org Received: (qmail 11047 invoked by uid 99); 19 Dec 2006 20:36:26 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Dec 2006 12:36:26 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: domain of yseeley@gmail.com designates 66.249.92.173 as permitted sender) Received: from [66.249.92.173] (HELO ug-out-1314.google.com) (66.249.92.173) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Dec 2006 12:36:16 -0800 Received: by ug-out-1314.google.com with SMTP id k40so2032016ugc for ; Tue, 19 Dec 2006 12:35:54 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:sender:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=M9FJqJhfAVZhuQ3BX6E47Ey1d+bd8vEsEIqt1lQilib6KUMDWYqCV65SLbBdxIHtzgB90DahoRwORiFasFJxvac42mC4XSHvO7DA26z//4fNWbi1pdD2Pzcx5rCccjKJbf08lG5cAdQRBeXUnWKbjP0FQK4WNtU2ac/QWrAAe4w= Received: by 10.82.190.2 with SMTP id n2mr1254269buf.1166560554709; Tue, 19 Dec 2006 12:35:54 -0800 (PST) Received: by 10.82.149.12 with HTTP; Tue, 19 Dec 2006 12:35:54 -0800 (PST) Message-ID: Date: Tue, 19 Dec 2006 15:35:54 -0500 From: "Yonik Seeley" Sender: yseeley@gmail.com To: java-dev@lucene.apache.org Subject: Re: ThreadLocal leak (was Re: Leaking org.apache.lucene.index.* objects) In-Reply-To: <20061219200242.46486.qmail@web50302.mail.yahoo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20061219200242.46486.qmail@web50302.mail.yahoo.com> X-Google-Sender-Auth: 54fbfba2f58f3fa4 X-Virus-Checked: Checked by ClamAV on apache.org On 12/19/06, Otis Gospodnetic wrote: > Bingo! :) I'll try the patch shortly and report back in a bit. Cool, since you can serve as a test-case, I'll hold of on committing until I hear how it works. > What do you think about that alternative approach I mentioned? Instead of having FieldCacheImpl be aware of all IndexReaders, have FieldCache be an inst var in IndexReader? I wonder why it wasn't done that way to start with.... perhaps to completely separate sorting from index reading. Anyway, it's not backward compatible, and it doesn't buy us much to change now does it? We would get rid of a singe hash lookup on the reader, which is insignificant compared to anything the FieldCache is used for anyway. -Yonik http://incubator.apache.org/solr Solr, the open-source Lucene search server --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org For additional commands, e-mail: java-dev-help@lucene.apache.org