Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: java-dev@lucene.apache.org
Received-SPF: neutral (herse.apache.org: local policy)
Date: Tue, 19 Dec 2006 11:50:07 -0800 (PST)
From: Chris Hostetter <hossman_lucene@fucit.org>
To: java-dev@lucene.apache.org
Subject: Re: ThreadLocal leak (was Re: Leaking org.apache.lucene.index.*
 objects)
In-Reply-To: <20061219192236.90542.qmail@web50314.mail.yahoo.com>
Message-ID: <Pine.LNX.4.58.0612191145350.21925@hal.rescomp.berkeley.edu>
References: <20061219192236.90542.qmail@web50314.mail.yahoo.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII


: Can anyone else have a look at the patch for LUCENE-651 (or just at
: FieldCacheImpl) and see if there is a quick fix?

If i'm not mistaken, isn't line #65 wrong? ...

      synchronized (readerCache) {
        innerCache = (Map) readerCache.get(reader);
        if (innerCache == null) {
          innerCache = new HashMap();
          readerCache.put(reader, innerCache);
          value = null;
        } else {
          value = innerCache.get(key);
        }
        if (value == null) {
          value = new CreationPlaceholder();
          innerCache.put(reader, value);          <--- L65
        }
      }


...why is the reader being used as the key of the innerCache? Shouldn't
the "key" (param) be used here? ... nothing seems to ever remove the
reader from the innerCache, so i don't see how the WeekHashMap readerCache
would ever let go of it either.


: Also, wouldn't it be better if IndexReaders had a reference to their
: copy FieldCache, which they can kill when they are closed?  What we have
: now is a chunky FieldCacheImpl that has references to IndexReaders, and
: doesn't know when they are closed, and thus it can't remove them and
: their data from its internal caches?

as i recall, we've discussed that on the mailing list as being a "better
API" for dealing with FieldCaches ... but it would be an API changes, and
no one has (as of yet) attempted it and submitted a patch.


-Hoss


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org