lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robert engels <reng...@ix.netcom.com>
Subject Re: [jira] Commented: (LUCENE-753) Use NIO positional read to avoid synchronization in FSIndexInput
Date Wed, 20 Dec 2006 02:20:08 GMT
That is what I did in my implementation.

It is easy to implement this as a protected abstract method in  
IndexInput, which uses synchronization (and seek(), read(byte 
[],off,len). In the 'real" version just override it to do it properly  
without using seek().




On Dec 19, 2006, at 7:40 PM, Yonik Seeley (JIRA) wrote:

>     [ http://issues.apache.org/jira/browse/LUCENE-753? 
> page=comments#action_12459805 ]
>
> Yonik Seeley commented on LUCENE-753:
> -------------------------------------
>
> CSIndexInput synchronization could also be elimitated if there was  
> a pread added to IndexInput
>
>   public abstract void readBytes(byte[] b, int offset, int len,  
> long fileposition)
>
> Unfortunately, that would break any custom Directory based  
> implementations out there, and we can't provide a suitable default  
> with seek & read because we don't know what object to synchronize on.
> Worth it or not???
>
>> Use NIO positional read to avoid synchronization in FSIndexInput
>> ----------------------------------------------------------------
>>
>>                 Key: LUCENE-753
>>                 URL: http://issues.apache.org/jira/browse/LUCENE-753
>>             Project: Lucene - Java
>>          Issue Type: New Feature
>>          Components: Store
>>            Reporter: Yonik Seeley
>>         Attachments: FSIndexInput.patch
>>
>>
>> As suggested by Doug, we could use NIO pread to avoid  
>> synchronization on the underlying file.
>> This could mitigate any MT performance drop caused by reducing the  
>> number of files in the index format.
>
> -- 
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the  
> administrators: http://issues.apache.org/jira/secure/ 
> Administrators.jspa
> -
> For more information on JIRA, see: http://www.atlassian.com/ 
> software/jira
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message