lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yonik Seeley (JIRA)" <j...@apache.org>
Subject [jira] Updated: (LUCENE-750) don't use finalizers for FSIndexInput clones
Date Sat, 16 Dec 2006 15:38:22 GMT
     [ http://issues.apache.org/jira/browse/LUCENE-750?page=all ]

Yonik Seeley updated LUCENE-750:
--------------------------------

    Attachment: IndexInput_finalizer.patch

Forgot to remove the finalizer from FSIndexInput in the first patch.
Note that I also removed the finalizer from FSIndexOutput because IndexWriter already has
a finalizer, and finalization for writers doesn't really make much sense.

Can anyone think of a reason we should keep the FSIndexOutput finalizer?

> don't use finalizers for FSIndexInput clones
> --------------------------------------------
>
>                 Key: LUCENE-750
>                 URL: http://issues.apache.org/jira/browse/LUCENE-750
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Search
>    Affects Versions: 2.0.1
>            Reporter: Yonik Seeley
>         Assigned To: Yonik Seeley
>         Attachments: IndexInput_finalizer.patch, IndexInput_finalizer.patch
>
>
> finalizers are expensive, and we should avoid using them where possible.
> It looks like this helped to tickle some kind of bug (looks like a JVM bug?)
> http://www.nabble.com/15-minute-hang-in-IndexInput.clone%28%29-involving-finalizers-tf2826906.html#a7891015

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message