lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] Assigned: (LUCENE-129) Finalizers are non-canonical
Date Mon, 18 Dec 2006 21:53:24 GMT
     [ http://issues.apache.org/jira/browse/LUCENE-129?page=all ]

Michael McCandless reassigned LUCENE-129:
-----------------------------------------

    Assignee: Michael McCandless  (was: Lucene Developers)

> Finalizers are non-canonical
> ----------------------------
>
>                 Key: LUCENE-129
>                 URL: http://issues.apache.org/jira/browse/LUCENE-129
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Other
>    Affects Versions: unspecified
>         Environment: Operating System: other
> Platform: All
>            Reporter: Esmond Pitt
>         Assigned To: Michael McCandless
>            Priority: Minor
>
> The canonical form of a Java finalizer is:
> protected void finalize() throws Throwable()
> {
>  try
>  {
>    // ... local code to finalize this class
>  }
>  catch (Throwable t)
>  {
>  }
>  super.finalize(); // finalize base class.
> }
> The finalizers in IndexReader, IndexWriter, and FSDirectory don't conform. This
> is probably minor or null in effect, but the principle is important.
> As a matter of fact FSDirectory.finaliz() is entirely redundant and could be
> removed, as it doesn't do anything that RandomAccessFile.finalize would do
> automatically.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message