[ http://issues.apache.org/jira/browse/LUCENE-719?page=comments#action_12451418 ]
Matthew Bogosian commented on LUCENE-719:
-----------------------------------------
Fair enough. Sorry, I missed that middle paragraph. I can't think of a reason to include maxDoc()
off the top of my head. I just noticed it wasn't a part of the class. Thanks though for the
consideration, and I apologize for not reading more carefully! :-)
> IndexModifier does not support all APIs from IndexWriter/IndexReader
> --------------------------------------------------------------------
>
> Key: LUCENE-719
> URL: http://issues.apache.org/jira/browse/LUCENE-719
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Affects Versions: 1.9, 2.0.0, 2.1, 2.0.1
> Environment: n/a
> Reporter: Matthew Bogosian
> Priority: Minor
>
> IndexModifer should probably provide all of the methods defined in both IndexReader and
IndexWriter. Currently it does not (e.g., IndexReader.maxDoc() is not available).
> One way to do this *might* be to have IndexReader and IndexWriter interfaces. For example:
> package org.apache.lucene.index.interface;
> public interface IndexReader {
> ...
> int maxDoc();
> ...
> }
> Then the IndexReader and IndexWriter classes could implement those interfaces:
> package org.apache.lucene.index;
> public abstract class IndexReader implements org.apache.lucene.index.interface IndexReader
{
> ...
> public int maxDoc() {
> ...
> }
> ...
> }
> The IndexModifier could then implement both:
> public class IndexModifier implements org.apache.lucene.index.interface IndexReader,
> org.apache.lucene.index.interface IndexWriter {
> ...
> }
> Anywhere an IndexWriter or IndexReader was needed, one would require an object which
implemented the appropriate interface:
> package org.apache.lucene.index;
> public class MultiReader extends IndexReader {
> ...
> MultiReader(org.apache.lucene.index.interface.IndexReader[] subReaders) {
> ...
> }
> ...
> }
> Just a thought....
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
|