Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: java-dev@lucene.apache.org
Mime-Version: 1.0 (Apple Message framework v752.2)
In-Reply-To: <060201c6e757$2c0e6630$6401a8c0@aroushlt>
References: <060201c6e757$2c0e6630$6401a8c0@aroushlt>
Content-Type: multipart/signed; micalg=sha1; boundary=Apple-Mail-3--916577357;
 protocol="application/pkcs7-signature"
Message-Id: <4A22F66E-F1BE-4A46-8BB2-FFDC4DEFFEED@aconex.com>
From: Paul Smith <psmith@aconex.com>
Subject: Re: Is it save to remove the throw from FastCharStream.refill() ?
Date: Wed, 4 Oct 2006 11:52:12 +1000
To: java-dev@lucene.apache.org

--Apple-Mail-3--916577357
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	charset=US-ASCII;
	delsp=yes;
	format=flowed

The throwing of an exception by this class is still being done on the  
Java side at this stage IIRC, and is also extremely bad for  
performance in Java.  However I think the client of the class (one of  
the Filters I think) is expecting the EOF exception as a signal that  
it has received the end of the stream for tokenization point of view.

I would love to get rid of it, but I think it will break a lot of  
behaviour.

cheers,

Paul Smith

On 04/10/2006, at 11:48 AM, George Aroush wrote:

> Hi folks,
>
> Over at Lucene.Net, we are trying to determine if it's safe to do the
> following change: http://issues.apache.org/jira/browse/LUCENENET-8
>
> Can you tell us, if this change is done on the Java Lucene code,  
> how it will
> effect Lucene?  Do you expect the it to run faster but more  
> importantly, is
> it safe?
>
> Thanks.
>
> -- George Aroush
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>
>


--Apple-Mail-3--916577357
Content-Transfer-Encoding: base64
Content-Type: application/pkcs7-signature;
	name=smime.p7s
Content-Disposition: attachment;
	filename=smime.p7s

MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIGmjCCAz8w
ggKooAMCAQICAQ0wDQYJKoZIhvcNAQEFBQAwgdExCzAJBgNVBAYTAlpBMRUwEwYDVQQIEwxXZXN0
ZXJuIENhcGUxEjAQBgNVBAcTCUNhcGUgVG93bjEaMBgGA1UEChMRVGhhd3RlIENvbnN1bHRpbmcx
KDAmBgNVBAsTH0NlcnRpZmljYXRpb24gU2VydmljZXMgRGl2aXNpb24xJDAiBgNVBAMTG1RoYXd0
ZSBQZXJzb25hbCBGcmVlbWFpbCBDQTErMCkGCSqGSIb3DQEJARYccGVyc29uYWwtZnJlZW1haWxA
dGhhd3RlLmNvbTAeFw0wMzA3MTcwMDAwMDBaFw0xMzA3MTYyMzU5NTlaMGIxCzAJBgNVBAYTAlpB
MSUwIwYDVQQKExxUaGF3dGUgQ29uc3VsdGluZyAoUHR5KSBMdGQuMSwwKgYDVQQDEyNUaGF3dGUg
UGVyc29uYWwgRnJlZW1haWwgSXNzdWluZyBDQTCBnzANBgkqhkiG9w0BAQEFAAOBjQAwgYkCgYEA
xKY8VXNV+065yplaHmjAdQRwnd/p/6Me7L3N9VvyGna9fww6YfK/Uc4B1OVQCjDXAmNaLIkVcI7d
yfArhVqqP3FWy688Cwfn8R+RNiQqE88r1fOCdz0Dviv+uxg+B79AgAJk16emu59l0cUqVIUPSAR/
p7bRPGEEQB5kGXJgt/sCAwEAAaOBlDCBkTASBgNVHRMBAf8ECDAGAQH/AgEAMEMGA1UdHwQ8MDow
OKA2oDSGMmh0dHA6Ly9jcmwudGhhd3RlLmNvbS9UaGF3dGVQZXJzb25hbEZyZWVtYWlsQ0EuY3Js
MAsGA1UdDwQEAwIBBjApBgNVHREEIjAgpB4wHDEaMBgGA1UEAxMRUHJpdmF0ZUxhYmVsMi0xMzgw
DQYJKoZIhvcNAQEFBQADgYEASIzRUIPqCy7MDaNmrGcPf6+svsIXoUOWlJ1/TCG4+DYfqi2fNi/A
9BxQIJNwPP2t4WFiw9k6GX6EsZkbAMUaC4J0niVQlGLH2ydxVyWN3amcOY6MIE9lX5Xa9/eH1sYI
Tq726jTlEBpbNU1341YheILcIRk13iSx0x1G/11fZU8wggNTMIICvKADAgECAgMPvmgwDQYJKoZI
hvcNAQEEBQAwYjELMAkGA1UEBhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkp
IEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBMB4XDTA1
MTAyODAzNTUwOFoXDTA2MTAyODAzNTUwOFowgZ0xDjAMBgNVBAQTBVNtaXRoMQ0wCwYDVQQqEwRQ
YXVsMRMwEQYDVQQDEwpQYXVsIFNtaXRoMSAwHgYJKoZIhvcNAQkBFhFwc21pdGhAYXBhY2hlLm9y
ZzEgMB4GCSqGSIb3DQEJARYRcHNtaXRoQGFjb25leC5jb20xIzAhBgkqhkiG9w0BCQEWFHRhbGxw
c21pdGhAZ21haWwuY29tMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAoFqv2aOz5VpQ
nFRvaOJqE2xCEmoyjdGFIQcfEKq+vVwkctKyWaqQ9stcUubJFZ9l/V6oWl+YhusV5EXzpNka81GL
ES+fG9h5THLV6h+f/wVhw2NdgAfPVn8ff+VuzwzLCBJ2l3OXVvpLEjq5eYSQn2DlvaJRLPmKfWMZ
DkvO6RjknVFLDoISLO6e2FhLqIla/uBmZZyxnk7HtyAjnNmwo3+493nUOtwUcCD/tOvjEns6e7eJ
rqnpbEKf/7XQrpsfIoeKe/DHhIgzqiK3b7dTFPmN70RoLn9XN0YoIXzNoX02Bjf8nz6/9JWoGwII
1BzEHgywCzJ/G/k8mGylrfQ9wwIDAQABo1cwVTBFBgNVHREEPjA8gRFwc21pdGhAYXBhY2hlLm9y
Z4ERcHNtaXRoQGFjb25leC5jb22BFHRhbGxwc21pdGhAZ21haWwuY29tMAwGA1UdEwEB/wQCMAAw
DQYJKoZIhvcNAQEEBQADgYEAert7B1pgBkz7IxdlziZzszpXNe04RVoPbKkKdxfCmAoiIwl3Ppj/
BwrS8OlzYRfQa8ASNYjsXQVU2ZJSZ6vFbtcHo8rzrv6icj0W7bZ1582ziryGzqpm1mxpGFStu1ZK
nO2+iCheCkeNyjVXYLbnl8vwGZDQSyGpEkT+GI5fB+oxggLnMIIC4wIBATBpMGIxCzAJBgNVBAYT
AlpBMSUwIwYDVQQKExxUaGF3dGUgQ29uc3VsdGluZyAoUHR5KSBMdGQuMSwwKgYDVQQDEyNUaGF3
dGUgUGVyc29uYWwgRnJlZW1haWwgSXNzdWluZyBDQQIDD75oMAkGBSsOAwIaBQCgggFTMBgGCSqG
SIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkFMQ8XDTA2MTAwNDAxNTIxMlowIwYJKoZI
hvcNAQkEMRYEFHse06j0uQajsiuokbZSunJUWMfvMHgGCSsGAQQBgjcQBDFrMGkwYjELMAkGA1UE
BhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1Ro
YXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBAgMPvmgwegYLKoZIhvcNAQkQAgsxa6Bp
MGIxCzAJBgNVBAYTAlpBMSUwIwYDVQQKExxUaGF3dGUgQ29uc3VsdGluZyAoUHR5KSBMdGQuMSww
KgYDVQQDEyNUaGF3dGUgUGVyc29uYWwgRnJlZW1haWwgSXNzdWluZyBDQQIDD75oMA0GCSqGSIb3
DQEBAQUABIIBAIRmKyDte4RzAf8ot+O1uDyH3qo6cJvcftu8tFpAewN6D8tT4dZj4fR12Nn3m27Z
LAPMxEdVAwoujlJPwqpYjMsUAj09t9/Gsz+kXLBSs0b4UAfMCdhECjNSMLfLAUawMWQsQwR2rvAu
ilDL4aW6Ff8oMI/QB6e/OXNWNCjmhsiX1UeO1GM1nd5vZFuor4HfRj8/5I08Vs5GblKQYanMZ48k
nfGCkvThrwMxHIZUADnkGG/hcoYFdfuaq1gcYwK7xJClcbzaSzjEVzkuOjVH1gbX0AHn9z6RLGob
L5PeTnDMOcGmCBf+AZB3ozzUIhEDfkGwFN+eA1T2DT/aw0uxRpAAAAAAAAA=

--Apple-Mail-3--916577357--