lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yonik Seeley" <yo...@apache.org>
Subject Re: LazyField retains temp char[] buffer
Date Mon, 09 Oct 2006 18:08:06 GMT
On 10/8/06, Grant Ingersoll <gsingers@syr.edu> wrote:
> I think I was modeling it after IndexInput which does a similar thing
> when reading in String data to avoid having to reallocate the buffer
> unless it is necessary.  But you're right, in looking at it now,
> there really is no need for it since the LazyField is instantiated
> each time it is read in.

Thanks for the confirmation, I just checked in a fix for this.


-Yonik
http://incubator.apache.org/solr Solr, the open-source Lucene search server


> On Oct 7, 2006, at 12:29 PM, Yonik Seeley wrote:
>
> > While reviewing some of the LazyField code in preparation for Solr
> > support,
> > https://issues.apache.org/jira/browse/SOLR-52
> > I noticed that the char[] used to read the String data is a member,
> > and thus kept around after the data is read and a String constructed.
> > It doesn't look like it serves any purpose... I assume this is just a
> > little oversight?

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message