lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andreas Neumann" <neun...@gmail.com>
Subject Re: [jira] Commented: (LUCENE-657) FuzzyQuery should not be final
Date Wed, 25 Oct 2006 18:02:28 GMT
Two comments:

1. In this particular case, all I need is the ability to override base
class method
   getEnum(). No need to access or change member variables. As the class already
   defines getters for the members, the members can remain private.

2. I noticed that many members have package (default Java) visibility.
An example is
   analysis.Token. Its two members startOffset and endOffset only have
getters, but no
   setters. If you want to set these after the Token was constructed,
you need to define
   a subclass in the org.apache.lucene.analysis package. In cases like
this, I don't think
   it would harm to make them protected, such that subclasses outside
the package
   can access them. Or add setters to the base class.

- Andreas.

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message